[8.x] Add option to set sendmail path. Fix default #5741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing this in an application, it would seem that sendmail -bs is the wrong option for this case?
What Laravel appears to do is pipe an RFC-2822 formatted message on STDIN and requires the sendmail emulation to deal with it,
rather than -bs which initiates an SMTP session.
if Exim is the default MTA then -t would seem to be the correct option.
If you have an alternative installed instead of sendmail/exim, then there's no way to set the path, so I added MAIL_SENDMAIL_PATH
so you can do, e.g.:
MAIL_SENDMAIL_PATH="/usr/bin/msmtp -t --tls=off --from=${MAIL_FROM_ADDRESS} --auto-from=off"
msmtp doesn't support -bs at all
GrahamCampbell
requested changes
Dec 3, 2021
config/mail.php
Outdated
| @@ -59,7 +59,7 @@ | |||
|
|
|||
| 'sendmail' => [ | |||
| 'transport' => 'sendmail', | |||
| 'path' => '/usr/sbin/sendmail -bs', | |||
| 'path' => env('MAIL_SENDMAIL_PATH', '/usr/sbin/sendmail -t'), | |||
There was a problem hiding this comment.
This change to the default we probably don't want?
|
As far as I can tell, the default does not work with either Exim or msmtp as the sendmail provider on Ubuntu at least in my testing, so I'm not sure what situation this does actually work?ROn 3 Dec 2021 20:47, Graham Campbell ***@***.***> wrote:
@GrahamCampbell requested changes on this pull request.
In config/mail.php:
@@ -59,7 +59,7 @@
'sendmail' => [
'transport' => 'sendmail',
- 'path' => '/usr/sbin/sendmail -bs',
+ 'path' => env('MAIL_SENDMAIL_PATH', '/usr/sbin/sendmail -t'),
This change to the default we probably don't want?
|
|
You may be correct here. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing this in an application, it would seem that sendmail -bs is the wrong option for this case?
What Laravel appears to do is pipe an RFC-2822 formatted message on STDIN and requires the sendmail emulation to deal with it,
rather than -bs which initiates an SMTP session.
if Exim is the default MTA then -t would seem to be the correct option.
If you have an alternative installed instead of sendmail/exim, then there's no way to set the path, so I added MAIL_SENDMAIL_PATH
so you can do, e.g.:
MAIL_SENDMAIL_PATH="/usr/bin/msmtp -t --tls=off --from=${MAIL_FROM_ADDRESS} --auto-from=off"
msmtp doesn't support -bs at all