[9.x] Use <env> element #5765
Merged
[9.x] Use <env> element #5765
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had an inkling that this used to use #27462 is the change in question, perhaps @GrahamCampbell can weigh in here, things may have changed in three years. |
|
@michaeldyrynda, yeah, maybe someone more familiar with the inner workings of Laravel might know why it needs to be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default configuration to avoiding a developer experience where you spend hours trying to determine why your CI configuration is not working.
The
<server>element has a higher than system environment variables (e.g.export APP_ENV=ci). As such, anything currently set inphpunit.xmlcan only be overridden by setting the configuration within your application (e.g.app()->config('app.env', 'ci')).The
<env>element is lower than system environment variables. For more detail, I wrote about configuration precedence during testing.Considering this repo is static, this could likely be retargeted at
8.x. However, I felt the upcoming9.xrelease provided a clean transition point.