Skip to content

[9.x] Adds Laravel v9.x to changelog #5803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2022
Merged

[9.x] Adds Laravel v9.x to changelog #5803

merged 2 commits into from
Feb 8, 2022

Conversation

nunomaduro
Copy link
Member

No description provided.

@taylorotwell taylorotwell merged commit 1d9e53f into 9.x Feb 8, 2022
@taylorotwell taylorotwell deleted the docs/changelog-9.x branch February 8, 2022 16:27
@driesvints
Copy link
Member

@stefanzweifel any idea why this wasn't done by the updater?

@stefanzweifel
Copy link

stefanzweifel commented Feb 8, 2022

@driesvints Honestly, can't tell. Might be a bug I haven't discovered yet. The combination of having an "Unreleased" heading but no other heading in the changelog isn't something currently covered by tests. Will add tests – and a possible bugfix – for this very soon.


The run received the following as the release notes:

Laravel 8 comes with a lot of changes to the base skeleton. Please consult the diff to see what's changed.

The workflow also created a commit but missing the input.

The 8.x run was successful and created the expected commit. 🤔

@driesvints
Copy link
Member

Yeah seems it's just missing the stuff nuno added here

@driesvints
Copy link
Member

Honestly it'll probably be fine from now on. Just wanted to mention it to you.

@stefanzweifel
Copy link

Yeah can confirm that's a bug. The CLI is looking for a previous heading, finds none and does … nothing.
https://github.com/stefanzweifel/php-changelog-updater/blob/main/app/Actions/PasteReleaseNotesBelowUnreleasedHeading.php#L56-L60

Sorry for that. At least I can promise it will work in Laravel 10 next year.

@driesvints
Copy link
Member

Cool, thanks! :)

@GrahamCampbell GrahamCampbell changed the title Adds Laravel v9.x to changelog [9.x] Adds Laravel v9.x to changelog Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants