-
Notifications
You must be signed in to change notification settings - Fork 24.4k
[9.x] Vite #5904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[9.x] Vite #5904
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| /node_modules | ||
| /public/build | ||
| /public/hot | ||
| /public/storage | ||
| /storage/*.key | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,5 +8,5 @@ php: | |
| js: | ||
| finder: | ||
| not-name: | ||
| - webpack.mix.js | ||
| - vite.config.js | ||
| css: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,14 @@ | ||
| { | ||
| "private": true, | ||
| "scripts": { | ||
| "dev": "npm run development", | ||
| "development": "mix", | ||
| "watch": "mix watch", | ||
| "watch-poll": "mix watch -- --watch-options-poll=1000", | ||
| "hot": "mix watch --hot", | ||
| "prod": "npm run production", | ||
| "production": "mix --production" | ||
| "dev": "vite", | ||
| "build": "vite build" | ||
| }, | ||
| "devDependencies": { | ||
| "axios": "^0.25", | ||
| "laravel-mix": "^6.0.6", | ||
| "laravel-vite-plugin": "^0.2.1", | ||
| "lodash": "^4.17.19", | ||
| "postcss": "^8.1.14" | ||
| "postcss": "^8.1.14", | ||
| "vite": "^2.9.11" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { defineConfig } from 'vite'; | ||
| import laravel from 'laravel-vite-plugin'; | ||
|
|
||
| export default defineConfig({ | ||
| plugins: [ | ||
| laravel([ | ||
| 'resources/css/app.css', | ||
| 'resources/js/app.js', | ||
| ]), | ||
| ], | ||
| }); |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this added?? I tried to use
npm run buildlocally so that my assets are production ready because I need to deploy to production, I was expecting that it should work on prod without the need to install npm packages...does this mean that i should do an
npm installthennpm run buildin prod?I'm getting error
Am I missing something here? maybe a link to a docs that helps me with deploying vite assets to prod?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never mind I found this https://github.com/laravel/vite-plugin/blob/main/UPGRADE.md#optional-git-ignore-the-build-directory
This is preference base and Laravel is just more inclined in building assets during deployment.
The
/public/buildcan just be commented out.