[9.x] Remove extra underscore from cache key prefix #5938
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5817 accidentally adds an excessive underscore to the end of the Redis cache key prefix, causing keys to become
laravel_cache_:key
instead of simplylaravel_cache:key
.A colon is already included at the end of the prefix for Redis, which occurs in
Illuminate\Cache\RedisStore.php
:This commit will simply undo the change to streamline the prefix as it was before without the underscore.
The issue mentioned in the PR linked above only affects the database cache driver, so it would be more efficient and consistent to just add a colon to the prefix in
Illuminate\Cache\DatabaseStore.php
instead. (laravel/framework#43123)