Skip to content

Add public/vendor to gitignore #6035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

slavarazum
Copy link

@slavarazum slavarazum commented Nov 18, 2022

According to #5904, we moved from committing compiled assets, to build them 👍

In addition Laravel vendor assets publishing fires by default on composer post-update-cmd event #5654

Adding the public/vendor directory to .gitignore will be suitable for these changes.

@driesvints
Copy link
Member

These assets are suppose to be committed.

@driesvints driesvints closed this Nov 18, 2022
@slavarazum
Copy link
Author

@driesvints Could you share a reason?

@driesvints
Copy link
Member

These assets are equivalent to the version that's locked in composer.lock so they need to be committed. Changing this would also require us to change the install docs of nova, telescope, horizon, etc

@slavarazum
Copy link
Author

From this point of view we can say that the assets in the build folder depend on the versions locked in package-lock.json so they need to be commited.
It looks contradictory that we don't commit the public/build folder now, but commit the public/vendor folder, but not commit /vendor folder.

As you have noticed these assets are equivalent to the version that's locked in composer.lock, in other words – just a copy from current vendor versions.
If we now required to launch npm install && npm run build to make client side ready to use it would be consistent to supplement this with the publication of the vendor assets.

If the question is on changing the docs, lets make a short conversation and I will do my best 🤝 🙂

Why wait four or five years (as it was with the main bundle) when we can bring such a simple and consistent change already #4118 #4625 #5646

@driesvints
Copy link
Member

We're not revising this, sorry.

@projct1
Copy link

projct1 commented Dec 17, 2023

These assets are equivalent to the version that's locked in composer.lock so they need to be committed. Changing this would also require us to change the install docs of nova, telescope, horizon, etc

That is, after installing the project through composer create-project you should always do git add .?
Is this considered the correct way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants