Revert "Fix incorrect collation for MySQL 8" #6240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c088b3b.
|
Hmm, I think we still need a solution for MySQL 8 here. It may be time to define a separate connection for Maria? |
taylorotwell
added a commit
that referenced
this pull request
Sep 18, 2023
christopheredjohnson
pushed a commit
to TheYGSGroup/laravel
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6239
It seems this collation is not supported for MariaDB:
https://mariadb.com/kb/en/supported-character-sets-and-collations/
I also tested it with Laravel Sail + MariaDB and it doesn't work:
In the original PR, @binaryfire asked if it possible to add a new config section for mariadb.