Skip to content

[11.x] Simplifies console routes #6309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[11.x] Simplifies console routes #6309

wants to merge 1 commit into from

Conversation

nunomaduro
Copy link
Member

@nunomaduro nunomaduro commented Jan 2, 2024 •
edited
Loading

This pull request uses laravel/framework#48137, to simplify the console routes. 💅🏻

Artisan::command('inspire', function () {
    $this->comment(Inspiring::quote());
})->purpose('Display an inspiring quote')->hourly();

@Jubeki
Copy link
Contributor

Jubeki commented Jan 2, 2024 •
edited
Loading

I would be in favour of leaving the Console Schedule Section with the following commented out for example:

// Schedule::command('model:prune')->daily();

I am also not sure, if anything should be scheduled by default. (Does inspire fill up the log files?)

@taylorotwell
Copy link
Member

Don't think we should do this atm.

@taylorotwell taylorotwell deleted the feat/simplifies-console-routes branch January 6, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorotwell taylorotwell Awaiting requested review from taylorotwell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nunomaduro @Jubeki @taylorotwell