Skip to content

Implement L11 welcome page design #6335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 28, 2024
Merged

Conversation

jasonlbeggs
Copy link
Contributor

@jasonlbeggs jasonlbeggs commented Feb 7, 2024

Once this PR is approved, we can upload the two screenshots to a CDN and I'll replace the links.

Then I'll submit PRs for the Vue and React versions in Breeze and Jetstream.

@mateusjatenee
Copy link

nice

@jasonlbeggs
Copy link
Contributor Author

I am curious to hear Taylor and the team's thoughts on color variables. I used pretty much all JIT colors here since the styles are inlined and we don't have a Tailwind config. With Breeze and Jetstream, there is a Tailwind config and I suppose we might want to update the auth/dashboard/profile views to match the new colors? Or do we just leave those as is and let the welcome page use slightly different colors? I'm open to thoughts and suggestions.

@taylorotwell taylorotwell marked this pull request as draft February 8, 2024 16:01
@antonkomarev
Copy link
Contributor

@jasonlbeggs could you provide screenshots before and after?

@timacdonald
Copy link
Member

we can upload the two screenshots to a CDN and I'll replace the links

Can we make sure to have a fallback here in case of CDN failure, i.e., an onerror hook that replaces the image tag with something else so that it looks good or re-styles the block in some way? This will ensure that the page looks good offline as well.

I also note that the size of the background SVG means that, at least on my machine (M1, 2020 Mac mini) in both Firefox and Safari, the browser is noticeably sluggish when resizing the browser window. It is usually only developers dragging browser widow corners, so usually I don't care about that kinda thing too much, but as this page is targeted at developers it feels important to leave a good first impression. We don't want a sluggish "basic" welcome page IMO. Maybe we should just capture the SVG as a PNG?

I also note that the SVG background image renders differently across Safari, Chrome, and Firefox.

Desktop screenshots

Firefox

Screenshot 2024-02-12 at 1 21 38 pm

Chrome

Screenshot 2024-02-12 at 1 22 00 pm

Safari

Screenshot 2024-02-12 at 1 21 42 pm

Lastly, due to the white Laravel logo and the way Safari renders the background it means the logo is rather hard to make out on mobile.

Mobile screenshot

IMG_DDF0FAE4129D-1

@jasonlbeggs
Copy link
Contributor Author

Thanks for the feedback @timacdonald! Ugh I thought I fixed the background image rendering differently in each browser. Yeah a PNG would probably be the easiest option for that. We can upload it to the CDN too.

I'll experiment with adding an onerror listener and see what looks best.

Do you have any opinions on the color naming that I mentioned in my previous comment?

@timacdonald
Copy link
Member

timacdonald commented Feb 12, 2024

I don't love the use of all inline colors, but I don't think it is a problem - just a feeling.

I don't think we should have different colors between the welcome page, Breeze, and Jetstream. The skeleton's welcome page becomes part of Breeze and Jetstream. A fresh Breeze install would see one color scheme for the homepage clicking the "login" link would have you land on a login screen with a different color scheme. We had that previously and it felt janky.

I standardised the colors for this reason: #6002

@jasonlbeggs
Copy link
Contributor Author

I can try refactoring to default Tailwind colors (except maybe the brand red) if @taylorotwell is cool with the design not matching perfectly. I'll also have to adjust the colors on the docs site screenshots to match.

@RobiNN1
Copy link

RobiNN1 commented Feb 12, 2024

Maybe will be good to convert images to data uri so there are no additional files.

@jasonlbeggs
Copy link
Contributor Author

Ok @timacdonald I've updated the design to use the default Tailwind colors and added an onerror hook to one of the screenshots so if it doesn't load, the page will adjust layout.

Normal circumstances:
image
image

Images don't load:
image
image

I also moved the background image to a real <img> tag to get around the sluggishness and browser differences.

Check it out and let me know if we're ready to move on to adding it to Breeze and Jetstream!

@Jubeki
Copy link
Contributor

Jubeki commented Feb 19, 2024

The images for images do not load show that the arrows are not aligned. (I like the new design)

@avinmaster
Copy link

avinmaster commented Feb 26, 2024

I couldn’t find where to write, I thought you would notice it here. Is there a need to make this repository as a template? For example, the repository of Django (https://github.com/django/django) is a template.

@driesvints
Copy link
Member

@avinmaster no need for that

@avinmaster
Copy link

@driesvints why? Maybe we have more reasons to make it so.

@jasonlbeggs jasonlbeggs marked this pull request as ready for review February 28, 2024 02:06
@taylorotwell taylorotwell merged commit f76b09d into laravel:master Feb 28, 2024
@jasonlbeggs jasonlbeggs deleted the 11-design branch February 28, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants