Improve static analysis by adding type hints for $app in artisan and public/index.php #6531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added PHPDoc type hints for the $app variable to improve static analysis support in PHPStan and PHPStorm. This prevents tools from incorrectly flagging the variable and enhances developer experience. No functional changes; only improves code readability and IDE support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit type hints for the $app variable in artisan and public/index.php using PHPDoc comments.
Why?
Impact
Testing
Since this change only affects static analysis, no functional tests are included. However, I can set up PHPStan within the test suite if desired.