feat: add type hints for $this in routes/console.php #6559
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a type hint for
$this
inroutes/console.php
, ensuring better IDE support and improved static analysis when working with console commands.Why This Change?
$this
within console command closures.$this
, reducing potential false positives in type checks.$this
as an instance ofIlluminate\Console\Command
makes the code easier to understand for new developers.Testing & Compatibility
Note: This replaces #6554, which I closed before realizing it was possible to properly hint the rebound scope. Thanks to @timacdonald for highlighting the dependency.
This further reinforces the importance of explicitly hinting both scopes, as they don’t seem to be well-documented elsewhere.