[12.x] PHPUnit 12 #6603
Closed
[12.x] PHPUnit 12 #6603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
requested changes
Apr 18, 2025
composer.json
Outdated
| @@ -17,7 +17,7 @@ | |||
| "laravel/sail": "^1.41", | |||
| "mockery/mockery": "^1.6", | |||
| "nunomaduro/collision": "^8.6", | |||
| "phpunit/phpunit": "^11.5.3" | |||
| "phpunit/phpunit": "^12.1.2" | |||
There was a problem hiding this comment.
PHPUnit 12 requires PHP 8.3 as minimum
There was a problem hiding this comment.
Suggested change
| "phpunit/phpunit": "^12.1.2" | |
| "phpunit/phpunit": "^11.5.3 || ^12.1.2" |
@crynobone Yeah, I just saw that too.
Should it be kept at PHPUnit 11 in the skeleton, or allow both?
GrahamCampbell
requested changes
Apr 18, 2025
|
Yeah, agree that this is not a blocker, maybe something for Laravel 13. Though it seems Symphony 8.0 will still require PHP 8.2, so I am not sure if it is necessary to bump Laravel to require PHP 8.3 for PHPUnit 12. (Development for Symfony 8.0 has not started yet, so it is possible that the PHP version bump happens sometime after May.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.