Wouldn't it be better to add Symfony\Component\HttpFoundation\LaravelResponse extends Symfony\Component\HttpFoundation\Response and only modify the send() method. By extending it, we can keep the original Symfony file unchanged and this helps during any upgrade of those components.

That was a good idea @crynobone, I hope this is more helpful.

Interesting. Anymore info on why it doesn't get called on fcgi?

Looks like there is another issue with Symfony component:
http://forums.laravel.com/viewtopic.php?pid=8648

So basically, in laravel/laravel.php, the laravel.done event gets fired after calling $response->send();,
The problem is that that method will stop the php (fcgi) process by calling fastcgi_finish_request(), and so the laravel.done never gets fired.

Calling laravel.done before sending the response would also solve this problem, but I am not sure of the importance of that.

My pull request will extend the Response class to stop the send() method from calling fastcgi_finish_request() and instead call it at a later time (after the laravel.done event is fired)

One way or another, we need to get this fixed =)

x

Swapping laravel.done and $response->send(); would be the easiest solution.
In profiler.php you will have to change

//<?
Event::listen('laravel.done', function($response)
{
    echo Profiler::render($response);
});

to

//<?
Event::listen('laravel.done', function($response)
{
    $response->setContent($response->getContent().Profiler::render($response));
});

Just spent some time tracking done this issue as well. @vespakoen findings are correct.

+1 for this, I had the same problem and this helped me. I also saw other people on #laravel experiencing this, as it keeps the Profiler from showing up.

+1

Spent an hour debugging and wondering why profiler doesn't show, while came up to this situation on fastcgi_finish_request.
Hope there will be a fix or pull request accepted.
+1

+1

We are facing the same issues.

A fix is highly appreciated!

@vespakoen

I tried to apply your fix but ran into this error:
Call to undefined method Laravel\Response::finish()

Shouldn't the laravel/response.php include the finish function?

After applying it like this, everything seems to work.

public function finish() {
    $this->foundation->finish();
}

Thanks for pointing this out @stefanneubig it is fixed now

Can you update the change log to log the fix? :)

I could, but It would very likely result in a conflict when merging this into the develop branch.
This pull-request is a month old (3.2 is the latest in the changelog)

I will add a commit that adds a comment to the finish() call, which should provide you with enough information to add to the changelog.

Is that allright? if not, I can make a new pull-request based off the latest develop branch.

👍

Are we happy with this one @taylorotwell , must be a pretty annoying bug for php-fcgi users?

Just would like to bump this up.

thanks!