Combined PR for #22, #23, #24 #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7bb189 to
c330612
Compare
This was referenced Feb 7, 2021
…sh->isFeatureDisabled()` This change allows for more complex strategies to be employed that rely on runtime data not available in the request.
- Changes cache TTL default to 15s, the standard default - Add unleash.cache.failover option that will pull the last successful result from the cache - This setting is independent of regular caching - The cache is always stored, to allow enabling the feature during a failure incidence - This change also moves the requests for features out of the constructor - Possible to use in Facades - Still "cached" for the lifetime of the Unleash object
c330612 to
bcb9cf3
Compare
|
I'd be much more comfortable releasing the features you've built incrementally @dshafik, especially as this PR is quite large. Hope that's ok, will close this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines #22, #23, and #24
This is necessary because the changes in #23 change the new tests in #22 (the order of accessing the config changes).
If you wish to accept all three PRs, just merge this one and close the others.