Bind GuzzleHttpClient as default client for Unleash. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxkxf
reviewed
Apr 8, 2021
src/ServiceProvider.php
Outdated
| @@ -15,9 +18,9 @@ class ServiceProvider extends IlluminateServiceProvider | |||
| public function register() | |||
| { | |||
| $this->mergeConfigFrom($this->getConfigPath(), 'unleash'); | |||
| $this->app ->when(Unleash::class)->needs(ClientInterface::class)->give(Client::class); | |||
There was a problem hiding this comment.
There looks to be a rogue space after app, is this needed?
There was a problem hiding this comment.
Sharp eyes! I have pushed an update.
mxkxf
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16 (comment)
(Finally :) )
From the suggestion by https://github.com/gsmofgsm in that thread.
This update provides
GuzzleHttp\ClientInterfaceas the default client for Unleash.In particular, it allows the use of the Facade without having to first bind Guzzle into the service container.