implemented Session.to_pickle #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cPickle was never used on Python2 because pickle exists :)
(ie check that array order is preserved)
gdementen
commented
May 4, 2017
| a0 | 0 | 1 | 2 | ||
| a1 | 3 | 4 | 5 | ||
| a2 | 6 | 7 | 8 | ||
| >>> arr.reindex(arr2.axes, fill_value=0) | ||
| a\\b | b0 | b1 | b2 |
There was a problem hiding this comment.
oups :) I need to change this :)
added more explanations for a few points, and moved stuff around
alixdamman
reviewed
May 4, 2017
There was a problem hiding this comment.
Given we merge this PR, do you want me to fix #241 before to release?
| it includes the number of values, mean, standard deviation, minimum, 25, 50 and 75 percentiles and maximum. | ||
| * viewer: added a menu bar with the ability to clear the current session, save all its arrays to a file (.h5, .xlsx, | ||
| .pkl or a directory containing multiple .csv files), and load arrays from such a file (closes :issue:`88`). | ||
|
|
There was a problem hiding this comment.
.pkl will contain more than the arrays ? Like user defined axes or groups ?
There was a problem hiding this comment.
no, it currently contains only the arrays, like other formats.
| self.session.save(fpath) | ||
| s = Session() | ||
| s.load(fpath, engine='pickle') | ||
| self.assertEqual(list(s.keys()), ['e', 'g', 'f']) | ||
|
|
There was a problem hiding this comment.
So here the saved/loaded session contains only LArray objects?
|
I now know the way I want to fix #241, but I am unsure we should do it for this release. |
|
OK, #241 will be fixed in the next release (0.23) |
alixdamman
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also contains other misc improvements