-
Notifications
You must be signed in to change notification settings - Fork 6
Wide arg read csv excel (issue #574) #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alixdamman
merged 2 commits into
larray-project:master
from
alixdamman:wide_arg_read_csv_excel_574
Feb 22, 2018
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
time,2007,2010,2013 | ||
a,a0,a1,a2 | ||
,0,1,2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
a,value | ||
a0,0 | ||
a1,1 | ||
a2,2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
a\b,0,1,2 | ||
0,0,1,2 | ||
1,3,4,5 | ||
a\b,b0,b1 | ||
1,0,1 | ||
2,2,3 | ||
3,4,5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,4 @@ | ||
age,2007,2010,2013 | ||
0,3722,3395,3347 | ||
1,338,316,323 | ||
2,2878,2791,2822 | ||
3,1121,1037,976 | ||
4,4073,4161,4429 | ||
a,b0,b1,b2 | ||
a0,0,1,2 | ||
a1,3,4,5 | ||
a2,6,7,8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
a,b,value | ||
1,b0,0 | ||
1,b1,1 | ||
2,b0,2 | ||
2,b1,3 | ||
3,b0,4 | ||
3,b1,5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,7 @@ | ||
age,sex\time,2015,2016,2017 | ||
0,F,0.5,1.5,2.5 | ||
0,M,3.5,4.5,5.5 | ||
1,F,6.5,7.5,8.5 | ||
1,M,9.5,10.5,11.5 | ||
2,F,12.5,13.5,14.5 | ||
2,M,15.5,16.5,17.5 | ||
3,F,18.5,19.5,20.5 | ||
3,M,21.5,22.5,23.5 | ||
a,b\c,c0,c1,c2 | ||
1,b0,0,1,2 | ||
1,b1,3,4,5 | ||
2,b0,6,7,8 | ||
2,b1,9,10,11 | ||
3,b0,12,13,14 | ||
3,b1,15,16,17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
a,b,c,value | ||
1,b0,c0,0 | ||
1,b0,c1,1 | ||
1,b0,c2,2 | ||
1,b1,c0,3 | ||
1,b1,c1,4 | ||
1,b1,c2,5 | ||
2,b0,c0,6 | ||
2,b0,c1,7 | ||
2,b0,c2,8 | ||
2,b1,c0,9 | ||
2,b1,c1,10 | ||
2,b1,c2,11 | ||
3,b0,c0,12 | ||
3,b0,c1,13 | ||
3,b0,c2,14 | ||
3,b1,c0,15 | ||
3,b1,c1,16 | ||
3,b1,c2,17 |
This file was deleted.
Oops, something went wrong.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
a,b\c,0,1,2 | ||
0,0,0,1,2 | ||
0,1,3,4,5 | ||
0,2,6,7,8 | ||
1,0,9,10,11 | ||
1,1,12,13,14 | ||
1,2,15,16,17 | ||
2,0,18,19,20 | ||
2,1,21,22,23 | ||
2,2,24,25,26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
a,b\c,c0,c1,c2 | ||
1,b0,0,1,2 | ||
1,b1,3,4,5 | ||
2,b1,9,10,11 | ||
3,b0,12,13,14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
a,b,c,value | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would be nice if this test also included missing values for c |
||
1,b0,c0,0 | ||
1,b0,c1,1 | ||
1,b0,c2,2 | ||
1,b1,c0,3 | ||
1,b1,c1,4 | ||
1,b1,c2,5 | ||
2,b1,c0,9 | ||
2,b1,c2,11 | ||
3,b0,c0,12 | ||
3,b0,c1,13 | ||
3,b0,c2,14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
a,b,c,value | ||
3,b1,c2,0 | ||
3,b1,c1,1 | ||
3,b1,c0,2 | ||
3,b0,c2,3 | ||
3,b0,c1,4 | ||
3,b0,c0,5 | ||
2,b1,c2,6 | ||
2,b1,c1,7 | ||
2,b1,c0,8 | ||
2,b0,c2,9 | ||
2,b0,c1,10 | ||
2,b0,c0,11 | ||
1,b1,c2,12 | ||
1,b1,c1,13 | ||
1,b1,c0,14 | ||
1,b0,c2,15 | ||
1,b0,c1,16 | ||
1,b0,c0,17 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using a0 etc... is probably a good idea, but then we need another test for "int" labels (to check they are parsed to int correctly and do not stay strings). This could use from_string or from_list instead of a file though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't already the case for
from_lists
andfrom_string
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the from_list test does not count as the year labels already are of the correct type (it uses 1991; not '1991'), and there is no test in from_string doctest with int-like labels in that last axis, and the tests do not check the type of the labels.