Skip to content

issue 26 (cleanup unit tests): rewritten test_array.py: unittest -> pytest #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2018
Merged

issue 26 (cleanup unit tests): rewritten test_array.py: unittest -> pytest #637

merged 1 commit into from
Jun 1, 2018

Conversation

alixdamman
Copy link
Collaborator

No description provided.

@alixdamman alixdamman requested a review from gdementen May 31, 2018 08:02
gdementen
gdementen approved these changes Jun 1, 2018
View reviewed changes
Copy link
Contributor

@gdementen gdementen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, this only changes the syntax of the tests to use pytest, right? This is a good thing to isolate the syntax changes from the "content" changes, but this does not closes #26.

@alixdamman
Copy link
Collaborator Author

Yes, that's why the commit message doesn't start with fix #26.

@alixdamman alixdamman merged commit 0157180 into larray-project:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdementen gdementen gdementen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alixdamman @gdementen