Skip to content

include missing ufuncs doc to API documention #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2018

Conversation

alixdamman
Copy link
Collaborator

readthedocs output is here: https://larray-test.readthedocs.io/en/documentation/api.html#utility-functions

I still need to find a way to run new specific doctests for where, maximum and minimum but let's start the discussion.

Issues #715 and #716 will be fixed in another PR.

@alixdamman alixdamman requested a review from gdementen November 22, 2018 11:51
@gdementen
Copy link
Contributor

BTW, could you make a separate PR with only the first commit? (and merge it directly, or even push directly to master without making a PR). I'd like to have that commit merged rather sooner than later.

Copy link
Contributor

@gdementen gdementen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alixdamman
Copy link
Collaborator Author

Of course, the changelog associated with issue 698 will need to be changed after fixing issue #723

…ufuncs.py modules + added explicit doc and examples for ufuncs where, maximum and minimum
@alixdamman alixdamman merged commit be493b3 into larray-project:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants