Skip to content

unsaved changes indicator in viewer #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alixdamman opened this issue Jul 6, 2017 · 3 comments
Closed

unsaved changes indicator in viewer #21

alixdamman opened this issue Jul 6, 2017 · 3 comments
Assignees
@alixdamman
Labels
enhancement
Milestone
0.26

Comments

@alixdamman
Copy link
Contributor

larray-project/larray#256
@alixdamman alixdamman added this to the 0.2 milestone Aug 28, 2017
@alixdamman
Copy link
Contributor Author

See also #22

@alixdamman
Copy link
Contributor Author

alixdamman commented Sep 8, 2017 •
edited
Loading

Should I follow the behavior of MappingEditor._unsaved_modifications (set to True when arrays have been added/deleted + user made some changes AND clicked on Apply) or should I update the indicator as soon as the user changed the value of any cell (before user clicked on Apply)?

Second question: MappingEditor._unsaved_modifications should be set to True as soon as the user changed the value of any cell (before user clicked on Apply)?

@gdementen
Copy link
Collaborator

Those two MUST be consistent, but yes _unsaved_modifications should ideally be True before apply.

alixdamman added a commit to alixdamman/larray-editor that referenced this issue Sep 11, 2017
@alixdamman
fix larray-project#21 : add marker * to the title when unsaved change…
a80d0a2 
…s are detected.

changed behavior of var unsaved_modifications (MappingEditor class): set to True as soon as data has been changed (before users click on Apply button)
alixdamman added a commit to alixdamman/larray-editor that referenced this issue Sep 11, 2017
@alixdamman
fix larray-project#21 : add marker * to the title when unsaved change…
02a4cb9 
…s are detected.

changed behavior of var unsaved_modifications (MappingEditor class): set to True as soon as data has been changed (before users click on Apply button)
alixdamman added a commit to alixdamman/larray-editor that referenced this issue Sep 11, 2017
@alixdamman
fix larray-project#21 : add marker * to the title when unsaved change…
867ac8a 
…s are detected.

changed behavior of var unsaved_modifications (MappingEditor class): set to True as soon as data has been changed (before users click on Apply button)
@alixdamman alixdamman self-assigned this Sep 13, 2017
alixdamman added a commit to alixdamman/larray-editor that referenced this issue Sep 13, 2017
@alixdamman
fix larray-project#21 : add marker * to the title when unsaved change…
0d1e226 
…s are detected.

changed behavior of var unsaved_modifications (MappingEditor class): set to True as soon as data has been changed (before users click on Apply button)
@gdementen gdementen mentioned this issue Oct 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alixdamman alixdamman

Labels
enhancement
Projects
None yet
Milestone
0.26
Development

No branches or pull requests
2 participants
@gdementen @alixdamman