issue 10: view several sessions same time #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implemented MapItems class - replaced the use of a QListWidget instance by a QTreeWidget instance
- added getitem_pattern and getattr_pattern - updated ipython_cell_executed()
…last executed command
gdementen
reviewed
May 21, 2019
larray_editor/editor.py
Outdated
| @@ -873,38 +873,34 @@ def ipython_cell_executed(self): | |||
| self.select_array_item(last_input) | |||
| return | |||
|
|
|||
| # check if expression of the kind '<varname>[(...)] (...)' or '<varname>.<attribute> (...)' | |||
| varname = itemname = None | |||
| m = getitem_pattern.match(last_input) | |||
There was a problem hiding this comment.
I don't know whether it is actually needed to check for setXXX patterns explicitly (previously the idea was to have setXXX for free from the getXXX pattern IIRC), but not checking at all for the getXXX pattern will introduce a slight regression AFAICT : it will not select the array (in the tree widget) if you type "income['M']" but will select it if you type "income". Did you intentionally remove that feature or was it an oversight?
There was a problem hiding this comment.
Hehe, I just checked and this didn't work previously. 😉 I wonder if we should support that or not.
There was a problem hiding this comment.
arr1 = ndtest((3, 4))
arr2 = ndtest((3, 4, 5))
arr1['b0']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet finished but I'm starting to get stuck in some difficulties and lack of specifications for which I need help.
To know what is working or not, see comment #10 (comment)
There are also TODOs in the code.