fix #75 : display a message when saving or loading a file failed #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and display a QMessageBox instead
gdementen
reviewed
Sep 27, 2017
larray_editor/editor.py
Outdated
| dirname = os.path.dirname(filepath[0]) | ||
| basenames = [os.path.basename(fpath) for fpath in filepath] | ||
| self.set_current_file(dirname) | ||
| self.statusBar().showMessage("CSV files {} loaded".format(' ,'.join(basenames)), 4000) | ||
| try: |
There was a problem hiding this comment.
Wouldn't it be better to merge both code paths and inline _update_arrays?
if isinstance(filepath, (list, tuple)):
filepath = None
names = filepath
...
current_file_name = dirname
display_name = ' ,'.join(basenames)
else:
names = None
current_file_name = filepath
display_name = filepath
try:
session.load(filepath, names)
self._reset()
self.set_current_file(current_file_name)
self._add_arrays(session)
self._listwidget.setCurrentRow(0)
self.unsaved_modifications = False
self.statusBar().showMessage("Loaded: {}".format(display_name, 4000))
except Exception as e:
QMessageBox.critical(self, "Error", "Something went wrong when loading: {}\n{}".format(display_name, e))886ae8a to
4148a7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.