Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove SignUpByEmail #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: remove SignUpByEmail #48

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a65bba0
fix: username is required when creating a new user
weakish Nov 16, 2021
877e937
feat: Remove SignUpByEmail
weakish Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: username is required when creating a new user 
Thank 沉寂 for bringing this to our attention.
  • Loading branch information
@weakish
weakish committed Nov 16, 2021
commit a65bba029812def069f500273c7c846b6f744447
4 changes: 3 additions & 1 deletion leancloud/users.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@ func (ref *Users) SignUpByMobilePhone(number, smsCode string) (*User, error) {

func (ref *Users) SignUpByEmail(email, password string) (*User, error) {
body := map[string]string{
"email": email,
"email": email,
// username & password fields are required for all users
"username": email,
Copy link
Contributor Author

@weakish weakish Nov 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果不指定 username，云端会报错

{"code":200,"error":"Username is missing or empty."}

不过其实我不是很确定 SignUpByEmail 这个接口当时引入的动机，其他 SDK 都没有凭邮箱注册的接口（只有凭邮箱登录的接口）。
可能这个留给应用层面决定更好，因为如果应用提供凭邮箱注册的功能，它可能设计成需要另外填用户名，也可能设计成用户名和邮箱一样，也可能设计成用户名随机生成。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我也没有印象，如果其他 SDK 都没有是不是应该去掉 ....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

去掉了（反正之前有 bug 也不能用，去掉也不破坏兼容性）

"password": password,
}
decodedUser, err := objectCreate(ref, body)
Expand Down