Fix CI windows release artifacts #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running on cpu without avx is unreasonably slow and all intel and amd cpus released in the last 10 years (more or less) support avx2. |
|
Thank you for your contribution. |
stduhpf
pushed a commit
to stduhpf/stable-diffusion.cpp
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows noavx build causes "Illegal instruction" errors on machines which lack AVX/AVX2 support.
Also stable-diffusion.cpp reports in verbose mode the following system info:
even through the machine has no AVX, AVX2, etc. support.
Depending on the github action runner the CI workflow is executed on the windows release artifacts seem to have deviating optimizations enabled.
It seems to be caused by GGML enabling
GGML_NATIVEby default which influences the enabled optimizations according to ggerganov/ggml/CMakeLists.txt#L96-L100 and ggerganov/ggml/CMakeLists.txt#L104-L106.