Add CosXL support #683
Open
Add CosXL support #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b0c158 to
a6bbebf
Compare
|
Hmm it looks like the |
|
That doesn't fix the other issue. Though it seems like when using AYS or Gits, the oversaturation is not as bad as with the default exponential schedule. (Discrete schedule is not working at all, maybe this is expected) |
|
Looks like adding a simple negative prompt helps a lot to mitigate the overasturation issue, but it still doesn't look quite right:
(ComfyUI doesn't need a negative prompt to generate good images with cosXL, so something fishy is going on here) |
stduhpf
commented
May 23, 2025
stduhpf
added a commit
to stduhpf/stable-diffusion.cpp
that referenced
this pull request
May 26, 2025
cosxl: smol cleanup CosXL: fix schedule choice Rename EDMVDenoiser Avoid inf for EDMVDenoiser + discrete schedule make parametrization flags public Fix CosXL with empty negative prompts Instruct-p2p support support 2 conditionings cfg Do not re-encode the exact same image twice pix2pix: fixes for 2-cfg Fix pix2pix latent inputs + improve inpainting a bit + fix naming prepare for other pix2pix-like models Support sdxl ip2p CoxXL edit: fix reference image embeddings Support 2-cond cfg properly in cli fix typo in help
stduhpf
added a commit
to stduhpf/stable-diffusion.cpp
that referenced
this pull request
May 26, 2025
cosxl: smol cleanup CosXL: fix schedule choice Rename EDMVDenoiser Avoid inf for EDMVDenoiser + discrete schedule make parametrization flags public Fix CosXL with empty negative prompts
stduhpf
added a commit
to stduhpf/stable-diffusion.cpp
that referenced
this pull request
May 26, 2025
cosxl: smol cleanup CosXL: fix schedule choice Rename EDMVDenoiser Avoid inf for EDMVDenoiser + discrete schedule make parametrization flags public Fix CosXL with empty negative prompts Instruct-p2p support support 2 conditionings cfg Do not re-encode the exact same image twice pix2pix: fixes for 2-cfg Fix pix2pix latent inputs + improve inpainting a bit + fix naming prepare for other pix2pix-like models Support sdxl ip2p CoxXL edit: fix reference image embeddings Support 2-cond cfg properly in cli fix typo in help Support masks for ip2p models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #630