Clarify lora quant support and small fixes #792
Merged
+49
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated lora.md to clarify that not all quants are supported * Fixed so --clip-on-cpu hint is not shown when using it * Creates parent directory if not exists * Added .idea folder used for CLion
|
This includes #785 |
|
Thank you for your contribution. However, please do not include IDE-related configurations in the project. This is not a recommended practice. |
|
The .idea folder has some files that makes sense to share among the team. https://rider-support.jetbrains.com/hc/en-us/articles/207097529-What-is-the-idea-folder I can change my PR to just Ignite .idea of you like anyway |
|
The metadata related to the IDE is not recommended to be placed in the project. Please remove the relevant files. |
|
I've updated to ignore .idea now |
|
Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.