fix: some tensors are in bf16 #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I forgot to do it for lora, I did it for model weights before. |
numpy does not support bf16, so we conservatively upcast to f32
37994d9 to
45c339d
Compare
|
ah right. thanks for correcting :) |
|
ah, you seem to down cast it to f16, have you seen any issues with that? I went with the safe route of upcasting to f32, since bf16 is a chopped-off f32. |
|
Nothing special, just maintaining consistency with the model. I've also forgotten why I initially converted to f16; it seems like f32 would be a better choice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy does not support bf16, so we conservatively upcast to f32.
I encountered some loras with (some?) tensors in bf16.