src: delete CallbackInfo when cleared from cleanup hook

Fixes: nodejs#32400 PR-URL: nodejs#32405 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
lfortin · Mar 23, 2020 · 678e1be · 678e1be
1 parent f2cc28a
commit 678e1be
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/node_buffer.cc b/src/node_buffer.cc
@@ -163,14 +163,14 @@ void CallbackInfo::WeakCallback(
     const WeakCallbackInfo<CallbackInfo>& data) {
   CallbackInfo* self = data.GetParameter();
   self->WeakCallback(data.GetIsolate());
-  delete self;
 }
 
 
 void CallbackInfo::WeakCallback(Isolate* isolate) {
   callback_(data_, hint_);
   int64_t change_in_bytes = -static_cast<int64_t>(sizeof(*this));
   isolate->AdjustAmountOfExternalAllocatedMemory(change_in_bytes);
+  delete this;
 }