Treat GIT_PASSTHROUGH as though git_cred_acquire_cb isn't set. #3528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks to dabble in the same areas as libgit2/libgit2sharp#1239. Are there any dependencies? |
|
@nulltoken They are certainly related, but I believe each change is useful by itself. If we make the LibGit2Sharp change and not this one, then null credentials wind up throwing a "No error message has been provided by the native library" error. That's not ideal, but it's better than the current behavior of throwing a |
|
@chescock Thanks for the feedback |
|
Thanks! |
ethomson
added a commit
that referenced
this pull request
Dec 14, 2015
…llback Treat GIT_PASSTHROUGH as though git_cred_acquire_cb isn't set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the winhttp transport treat a GIT_PASSTHROUGH returned from the credential handler the same as if there was no handler. This matches the documentation for
git_remote_callbacks.credentialsand the implementations of the http and ssl transports.