win32: choose the page size as our value for the page size #3690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. It's okay to change the page size that we use for pools, but mmap emulation is a bit stricter. We need to observe the allocation granularity for
|
763384e to
ed83988
Compare
While often similar, these are not the same on Windows. We want to use the page size on Windows for the pools, but for mmap we need to use the allocation granularity as the alignment. On the other platforms these values remain the same.
ed83988 to
87c1819
Compare
ethomson
pushed a commit
that referenced
this pull request
Mar 16, 2016
win32: choose the page size as our value for the page size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using the allocation granularity instead for this value,
but his refers to VirtualAlloc() rather than anything we do. Using this
as a value for the pool means every pool would become at least 64kB with
foreseeable results on memory pressure.
Do use the system's page size as our value for the page size.