Skip to content

Make type mismatch errors consistent #5359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tniessen
Copy link
Contributor

The same error message appears in other places with the word "the" included. API consumers in higher-level languages such as JavaScript (via nodegit) might consume these strings, so they should be consistent.

@ethomson
Copy link
Member

Good eye. Thanks for the fix.

@ethomson ethomson merged commit dea5ce3 into libgit2:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants