Skip to content

Fix LIBGIT2_FILENAME not being passed to the resource compiler #5994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2021
Merged

Fix LIBGIT2_FILENAME not being passed to the resource compiler #5994

merged 1 commit into from
Aug 17, 2021

Conversation

jairbubbles
Copy link
Contributor

@jairbubbles jairbubbles commented Aug 17, 2021 •
edited
Loading

LIBGIT2_FILENAME was not being passed to the resource compiler anymore since #5547

It is used when compiling native binaries for libgit2sharp and was detected in libgit2/libgit2sharp.nativebinaries#114.

@jairbubbles jairbubbles marked this pull request as ready for review August 17, 2021 09:51
@jairbubbles jairbubbles mentioned this pull request Aug 17, 2021
Merged
@ethomson
Copy link
Member

Thanks for the fix!

@ethomson ethomson merged commit a7b2195 into libgit2:main Aug 17, 2021
@jairbubbles jairbubbles mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethomson ethomson ethomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jairbubbles @ethomson