Skip to content

ssh: fix known_hosts leak in _git_ssh_setup_conn #6599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2023
Merged

ssh: fix known_hosts leak in _git_ssh_setup_conn #6599

merged 1 commit into from
Jul 30, 2023

Conversation

steven9724
Copy link
Contributor

In _git_ssh_setup_conn, known_hosts is allocated by _git_ssh_session_create. However, known_hosts is only cleaned up in the case of error.

This moves the cleanup code for known_hosts so that its run in the error an success case.

Fixes #6598

@ethomson
Copy link
Member

Thanks for the fix!

@ethomson ethomson merged commit 782c4d4 into libgit2:main Jul 30, 2023
@ethomson ethomson added the v1.7 label Jul 30, 2023
@ethomson ethomson mentioned this pull request Aug 2, 2023
Merged
@ethomson ethomson added the bug label Aug 14, 2023
@branchvincent branchvincent mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSH connections leak memory
2 participants
@steven9724 @ethomson