-
Notifications
You must be signed in to change notification settings - Fork 2.5k
process.c: fix environ for macOS #6792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise this happens:
|
What version(s) of macOS lacks this? |
Thank you for responding. Implementation which I suggest (which is the standard one in fact) works from 10.4 through the latest 14.4.x. |
@ethomson Perhaps Windows CI failure is unrelated? |
12 tasks
Thanks for the fix — yes, totally unrelated. 🙏 |
ethomson
approved these changes
Apr 19, 2024
@ethomson Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bc97d01 commit introduced
environ
usage which is not compatible with some version of macOS. In resultlibgit2
cannot be built.Fix that: use a MacOS-specific symbol on macOS.