Skip to content

Headers cleanup #6842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2024
Merged

Headers cleanup #6842

merged 2 commits into from
Jul 12, 2024

Conversation

anatol
Copy link
Contributor

@anatol anatol commented Jul 3, 2024

A small cleanup for libgit2 headers

@ethomson
Copy link
Member

ethomson commented Jul 3, 2024

Oops, good catch on email_from_diff. It was actually supposed to be in the sys/email.h header. Would you mind zapping it from email.h instead? 🙏

@anatol
Copy link
Contributor Author

anatol commented Jul 4, 2024

Oops, good catch on email_from_diff. It was actually supposed to be in the sys/email.h header. Would you mind zapping it from email.h instead? 🙏

Sure, done. It turns there are some users that expect the function to be at git2/mail.h, so I fixed them as well.

@ethomson
Copy link
Member

Awesome, thanks! 🙏

anatol added 2 commits July 10, 2024 17:14
@anatol
Use typedef type for git_odb
0c39ee1 
This makes the function signature consistent with other cases
@anatol
Remove duplicating declaration of git_email_create_from_diff()
1f83c46 
Exactly the same function already declared in include/git2/email.h
@anatol
Copy link
Contributor Author

anatol commented Jul 11, 2024

@ethomson could you please approve the github workflow to see if my last patch fixes the compilation issue?

@ethomson
Copy link
Member

Thanks!

@ethomson ethomson merged commit d58db64 into libgit2:main Jul 12, 2024
@ethomson ethomson added the bug label Sep 29, 2024
@BrewTestBot BrewTestBot mentioned this pull request Dec 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anatol @ethomson