refspec: Detect DEL character in is_valid_name #7120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch the code correctly barfed on control characters with values lower than \040 (space), but failed to account for DEL. This patch fixes the behavior to be consistent with git [1]: > They cannot have ASCII control characters (i.e. bytes whose values are > lower than \040, or \177 DEL) [1]: https://git-scm.com/docs/git-check-ref-format#_description
|
@pks-t, could you take a quick look? We've started using libgit2 refname validation logic in Nix (NixOS/nix#13729) and found that libgit2 is not entirely correct it seems. It would also be great to expose additional knobs for checking shorthand refnames directly, without going through the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch the code correctly barfed on
control characters with values lower than \040 (space), but failed to account for DEL.
This patch fixes the behavior to be consistent with git 1: