Fixes Coverity NullReferenceException Issues #1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -251,7 +251,7 @@ public virtual Blob CreateBlob(Stream stream, long numberOfBytesToConsume) | |||
|
|
|||
| using (var odbStream = Proxy.git_odb_open_wstream(handle, numberOfBytesToConsume, GitObjectType.Blob)) | |||
| { | |||
| var buffer = new byte[4*1024]; | |||
| var buffer = new byte[4 * 1024]; | |||
There was a problem hiding this comment.
Spaces are bad? Not sure what you mean here. Is it just that the Roslyn autoformatter struck again?
There was a problem hiding this comment.
Is it just that the Roslyn autoformatter struck again?
@whoisj I'm not against spaces 😉 However, I'd rather keep (unrelated) beautification in separate commits.
There was a problem hiding this comment.
Ah gotcha - @#$%! Roslyn and her free beautification on every } and ; 😁
|
@nulltoken fixed up. Removed my fixes for Version.cs |
nulltoken
added a commit
that referenced
this pull request
Jun 9, 2015
Fixes Coverity NullReferenceException Issues
|
🎱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new-again Coverity scanning has started to bear fruit. Here are some of the NRE issues identified by the scan. Minor fixes, low risk. Not sure if I'm throwing the correct exception types here (/CC @nulltoken).
nullwhen dealing with p/invoke and handles.