Take a name instead of an instance to update a remote #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5295c7e to
a5a583a
Compare
|
This needs libgit2/libgit2#3703 since writing multivars under lock is buggy for silly reasons. |
a5a583a to
b941ec1
Compare
All the Remote instance does in RemoteUpdater is carry the name, as we need it in order to perform the update. Reflect this in the class fields as well as in the preferred way of calling it. While we're dealing with the updater, make it perform its actions inside a configuration transaction so the configuration does not change while we're processing updates.
b941ec1 to
3b308f4
Compare
|
libgit2/libgit2#3703 landed in our natives, so this looks good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the Remote instance does in RemoteUpdater is carry the name, as we
need it in order to perform the update. Reflect this in the class fields
as well as in the preferred way of calling it.
While we're dealing with the updater, make it perform its actions inside
a configuration transaction so the configuration does not change while
we're processing updates.