Move Stage and Remove to commands #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e0e87c to
935c5df
Compare
|
Sorry, after merging #1288, there's conflicts here now. :/ |
These commands work on a repository, and we can leave the Index be the data structure. Thus it is no longer written to disk after every change.
This deprecates them from the repository itself and makes it clear this isn't a fundamental operation but something which builds on them.
935c5df to
78be980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to the other PRs, let's move away from having these in the repository. Making this external also means it'll work for more situations than it used to since now it expects to work against an
IRepositoryinstead of from inside aRepository.This also has us make the
Indexnot write itself to disk on every single operation, so we end up doing less I/O while we build up the index we do want to keep.I think this would be something you use @niik so do you have thoughts?