Skip to content

Update NativeBinaries to 1.0.235 #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Conversation

ethomson
Copy link
Member

@ethomson ethomson commented Oct 7, 2018

No description provided.

@bording
Copy link
Member

bording commented Oct 7, 2018

Bumping up to 235 here does mean that the 0.25 release will get a NativeBinaries version that has the more expanded native binary set, which has previously only been in the 0.26 prereleases.

Not sure that's a problem, just wanted to point out the change.

@ethomson
Copy link
Member Author

ethomson commented Oct 7, 2018

It will - and the underlying LibGit2Sharp here doesn’t know anything about them, so many of the binaries are largely useless and will never get loaded by anyone. I’m disappointed that we’ll be bloating the nuget restore process for people for no benefit but I think I’m happier with that than trying to create another new (but different) native binaries package for the libgit2 point release.

@bording
Copy link
Member

bording commented Oct 8, 2018

It will - and the underlying LibGit2Sharp here doesn’t know anything about them, so many of the binaries are largely useless and will never get loaded by anyone.

That isn't true. 0.25.x targets netstandard2.0, so the extra binaries will be used in the same way that they are in 0.26.x.

@ethomson
Copy link
Member Author

ethomson commented Oct 8, 2018

That isn't true. 0.25.x targets netstandard2.0, so the extra binaries will be used in the same way that they are in 0.26.x.

Oh, cool. I thought that #1571 was required for the multiple platforms. Nice to know that the extra MBs aren't for naught.

@ethomson ethomson merged commit 2f4f98c into maint/v0.25 Oct 8, 2018
@ethomson ethomson deleted the ethomson/update_natives_025 branch February 15, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants