Skip to content

Update NativeBinaries to 1.0.258 #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2018
Merged

Update NativeBinaries to 1.0.258 #1645

merged 2 commits into from
Nov 29, 2018

Conversation

ethomson
Copy link
Member

No more zlib or libcurl dependencies!

No more zlib or libcurl dependencies.
@bording
Copy link
Member

bording commented Nov 29, 2018

Hmm, test failures. That's unexpected!

@ethomson
Copy link
Member Author

This is an update to libgit2's master branch - and we're updating from the v0.25 branch, so there's actually been feature work going on that we need to respond to. In particular there were some changes around config settings that I think renders this test obsolete.

@bording
Copy link
Member

bording commented Nov 29, 2018

In particular there were some changes around config settings that I think renders this test obsolete.

Ok that's good. I was thinking that somehow the zlib removal was responsible!

Add the `include_depth` field to mirror the libgit2 addition.
@ethomson
Copy link
Member Author

libgit2 changed the git_config_entry structure, we just needed to update ours to match.

@ethomson ethomson merged commit 7e44514 into master Nov 29, 2018
@ethomson ethomson deleted the ethomson/natives branch February 15, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants