Make repo.Init() accept a separate git dir #453
Conversation
|
I think I'm missing something...why can't either |
|
@dahlbyk I thought about this option for a while. However, I haven't been able to convince myself that adding this additional parameter while still accepting a Beside this, I think that a |
|
Ready for review |
| var scd1 = BuildSelfCleaningDirectory(); | ||
| var scd2 = BuildSelfCleaningDirectory(); | ||
|
|
||
| var gitDir = Path.Combine(scd2.DirectoryPath, ".git/"); |
There was a problem hiding this comment.
Not sure if it matters, but what happens if we pass ".git" at the end, without the trailing slash?
There was a problem hiding this comment.
Not sure if it matters, but what happens if we pass ".git" at the end, without the trailing slash?
@yorah Could you submit a PR with some additional test coverage regarding this?
|
👍 |
Relates to http://stackoverflow.com/q/17126448
Try to find a way through deprecation rather than through breaking changesClone()return a string instead of an instance of aRepositoryNote: "Initializing a repository" and "Opening a repository" are different concerns and require different kind of parameters. Thus repo.Init() won't return a instance of a Repository any longer.