Introduce GlobalSettings.Features() #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Idea: leverage this to auto-skip tests that require certain features. Also, should the enum have a default value (None or similar)? |
I think so? Is |
|
(Oops, fat-fingered the close button there.) |
| public enum BuiltInFeatures | ||
| { | ||
| /// <summary> | ||
| /// Threading support is compiled in to libgit2. |
There was a problem hiding this comment.
Shouldn't it be into here and below?
|
Updated with the comments; not sure why travis is being so slow here. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow consumers to see what features are included with the libgit2 build that is being used.
Right now we do a little scrubbing in our UI so that we display nicer error messages when somebody tries to clone an
ssh://URL, since we do not yet support SSH. (Instead of saying "This version of libgit2 was not built with SSH support", which is some very leaky abstraction.) If somebody were to bring their own libgit2 to the party, though, it would be nice if we would not do this, and instead just pass the URL right down to libgit2.Thus we would like to query the built features.