Skip to content

Test making two successive commits to same file. #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kitbellew
Copy link

@nulltoken This test fails on Windows and on the Mac.

This test fails on Windows and on the Mac.
@nulltoken
Copy link
Member

@kitbellew the Exception that is throw is the one below:

LibGit2Sharp.EmptyCommitException: No changes; nothing to commit.

Which is raised when the commit being created bears no difference with its parent. I think this issue actually share the same root cause than #688.

Can you please confirm that the issue disappears if you (hackily) introduce a Thread.Sleep() between the two calls to WriteAndCommit?

@kitbellew
Copy link
Author

@nulltoken Emeric, thank you very much, adding a Thread.Sleep(1000) or storing "ab" in the second invocation (thus changing the file size) both fix the problem.

Should I close this? (After #688 is fixed, a test would be nice.)

@nulltoken
Copy link
Member

@kitbellew Glad I could help. Sorry for the less than awesome workaround.

Should I close this? (After #688 is fixed, a test would be nice.)

Let's close this one. #688 won't be closed until the test code in the issue description is committed into StageFixture.cs and passes.

@nulltoken
Copy link
Member

@kitbellew I turned issue #688 into a PR with the said failing test

@kitbellew kitbellew closed this Jun 3, 2014
@nulltoken nulltoken added this to the UnmergedOrDoNotRequireAFix milestone Jun 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants