Skip to content

Don't build with STDCALL #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Don't build with STDCALL #86

wants to merge 1 commit into from

Conversation

ethomson
Copy link
Member

@ethomson ethomson commented Jan 9, 2019

Creating a package built with cdecl instead of stdcall; I'd like to move libgit2 over to all-cdecl, the reason it supports the stdcall option is LibGit2Sharp. It should be easy to update the calling convention attributes in LibGit2Sharp for compatibility.

@bording
Copy link
Member

bording commented Jan 9, 2019

This seems like it would be okay to change, but it does mean that any future 0.25.x maintenance releases would have to have the cdecl changes brought over as well.

@ethomson
Copy link
Member Author

ethomson commented Jan 9, 2019

This seems like it would be okay to change, but it does mean that any future 0.25.x maintenance releases would have to have the cdecl changes brought over as well.

In that case, we should strongly consider creating a maintenance branch for that. 🤔

@ethomson
Copy link
Member Author

ethomson commented Jan 9, 2019

(I'm surprised we haven't done maintenance branches before, I'm surprised that we haven't had breaking API changes affect us. 🤷‍♂️ )

@bording
Copy link
Member

bording commented Jan 9, 2019

We could do a maintenance branch here, but all of the infrastructure around how the the various assets get collected into the package and then versioned doesn't really have a way to accommodate anything other than an ever increasing 1.0.xxx version scheme, so you'd have a later version of the package being the "maintenance" release.

Since we always lock LibGit2Sharp to a specific version, that won't actually be a problem, but it would result in some odd versions for this package.

@ethomson
Copy link
Member Author

ethomson commented Jan 9, 2019

Since we always lock LibGit2Sharp to a specific version, that won't actually be a problem, but it would result in some odd versions for this package.

Yeah, I thought about that. We could bump the new ones so that they were 2.0.xxx where xxx continues to auto-increment. As you point out, it's not completely necessary but it would avoid those weird looking numbers.

@bording
Copy link
Member

bording commented Jan 9, 2019

Yeah, I thought about that. We could bump the new ones so that they were 2.0.xxx where xxx continues to auto-increment. As you point out, it's not completely necessary but it would avoid those weird looking numbers.

That does seem like a reasonable way to handle it. That at least would keep things sorted properly.

@ethomson ethomson closed this Feb 5, 2019
@bording bording deleted the ethomson/cdecl branch February 5, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants