Refactor KeyboardMonitor to use generic event system #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the KeyboardMonitor implementation to use the existing generic event system instead of the legacy callback-based KeyboardEventHandler approach, providing better type safety, consistency, and maintainability.
Changes Made
New Event System Integration
KeyPressedEvent
,KeyReleasedEvent
, andModifierKeysChangedEvent
that inherit fromTypedEvent<T>
EventDispatcher
AddListener()
,RemoveListener()
, and template-based listener management methodsPlatform Implementation Updates
All platform-specific implementations (Linux X11, macOS CoreGraphics, Windows Win32) have been updated to:
DispatchEvent()
method to send keyboard events to registered listenersBackward Compatibility
native_keyboard_monitor_*
functions) continues to work unchanged by converting C callbacks to event listeners internallyCode Quality Improvements
KeyboardEventHandler
class and associated callback infrastructureModifierKey
enum to enable proper flag combinationsBenefits
Testing
The refactoring maintains full backward compatibility while modernizing the internal architecture to use the library's established event system patterns.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com
/usr/lib/apt/methods/https
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.