[Linux] Implement WindowManager class with GTK backend #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the missing
WindowManager
class for Linux platform using GTK/GDK APIs, completing the cross-platform window management functionality.Problem
The repository had
WindowManager
implementations for macOS and Windows, but Linux was missing, causing build failures and preventing Linux users from utilizing window management features:Solution
Added complete Linux implementation with GTK3 backend:
Core Implementation
src/platform/linux/window_manager_linux.cpp
- Implements the three core methods:Get(WindowID id)
- Retrieves window by ID using GTK window enumerationGetAll()
- Lists all application windows viagtk_window_list_toplevels()
GetCurrent()
- Finds focused window using GDK seat/device APIssrc/platform/linux/window_linux.cpp
- CompleteWindow
class implementation with GDK backend supporting all window operations (focus, show/hide, maximize/minimize, positioning, etc.)Technical Details
DisplayManager
GdkWindow*
instead ofNSWindow*
gtk_init_check()
Build System Fixes
CMAKE_SYSTEM_NAME STREQUAL "Linux"
instead ofLINUX
)Testing
The implementation has been thoroughly tested:
Compatibility
This implementation maintains full API compatibility with existing macOS/Windows versions while providing platform-appropriate behavior using GTK conventions.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com
/usr/lib/apt/methods/https
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.