Add support for building libsigc++-3.0 with Meson #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libsigc++-3.0 can be built with either Autotools or Meson.
We need to make sure that SIGC_BUILD and _WINDLL are defined when building the libsigc++ DLL, so that it gets build properly.
Instead of showing that 'mm-common-get' is not found, state that it is required for maintainer-mode.
This avoids warnings and mis-compilations on certain system locales when building on Visual Studio, in particular Chinese, Japanese and Korean versions of Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows how libsigc++-3.0 (master branch) can be built with Meson instead
of Autotools. libsigc++-3.0 does not contain built source code, which simplifies
the meson.build files, compared to for instance libsigc++-2.0 and pangomm.
When building libsigc++-3.0 in maintainer-mode, the mm-common-get command must be
available, but M4 is not used.
I have copied meson.build files from pangomm and modified them.
docs/docs/manual/libsigc_manual.xml is converted to html files and a pdf file
in a way similar to what's done in gtkmm-documentation.
@fanc999 and other persons working with MSVC:
Can this be used for MSVC builds? Are modifications necessary?
Can MSVC build directly from git, now that M4 is not used?
M4 is used when building libsigc++-2.0 (libsigc++-2-10 branch) from git,
but it's not used when building libsigc++-3.0 (master branch) from git.