Skip to content

Meson build: fix versioning on macOS #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

tschoonj
Copy link
Contributor

This is necessary to ensure backwards compatibility with the libtool versioning scheme on macOS.

This PR is against the 2.10 branch. If this one is accepted, I will gladly open a similar one against master as well.

@kjellahl
Copy link
Contributor

These versions really confuse me. And I admit that I haven't thought about macOS.
I didn't even know that it has its own versioning rules.

My intention with libtool_soversion is that its 3 list elements shall correspond to
what libtool calls current:revison:age, so

current = libtool_soversion[0]
revision = libtool_soversion[1]
age = libtool_soversion[2]

That's not how you have interpreted it in your PR, where you set

current = libtool_soversion[0] + libtool_soversion[1]
revision = libtool_soversion[2]

It doesn't make a difference when libtool_soversion = [0, 0, 0].

@tschoonj
Copy link
Contributor Author

You're right, I made a mistake (even though it doesn't matter in this case as you pointed out).

I will push a fix right away.

@kjellahl kjellahl merged commit 2c24f3f into libsigcplusplus:libsigc++-2-10 Sep 28, 2020
kjellahl pushed a commit that referenced this pull request Sep 28, 2020
@kjellahl
Copy link
Contributor

I have merged this PR and pushed a similar commit to the master branch.

Do you want a new libsigc++ release pretty soon because of this?

I suppose that darwin_versions must be added to other modules where I have added
Meson support. (cairomm, glibmm, atkmm, pangomm, gtkmm, libxml++; most of them at
https://gitlab.gnome.org/GNOME)

gnomesysadmins pushed a commit to GNOME/mm-common that referenced this pull request Sep 29, 2020
@tschoonj
Copy link
Contributor Author

Thanks for merging the PR in. A new release is not urgent, as I have already added the patch to the Homebrew formula.

The other modules will indeed need similar patches.

gnomesysadmins pushed a commit to GNOME/glibmm that referenced this pull request Sep 30, 2020
gnomesysadmins pushed a commit to GNOME/glibmm that referenced this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants