Skip to content

Add missing perfect forwarding in bound_mem_functor::operator() #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2021
Merged

Add missing perfect forwarding in bound_mem_functor::operator() #77

merged 2 commits into from
Dec 23, 2021

Conversation

slavaandrejev
Copy link
Contributor

This is a missed addition to the commit that allowed rvalue references
in slot parameters.

@slavaandrejev
Add missing perfect forwarding in bound_mem_functor::operator()
51d823b 
This is a missed addition to the commit that allowed rvalue references
in slot parameters.
@slavaandrejev
Copy link
Contributor Author

@kjellahl can you take a look?

@kjellahl
Copy link
Contributor

Looks fine, but I wonder if it's still incomplete.
Don't you need to add std::forward also in mem_functor::operator() (in mem_fun.h)
and in pointer_functor::operator() (in ptr_fun.h)?

@slavaandrejev
Add missing perfect forwarding in mem_functor and pointer_functor
928d29e 
This is a missed addition to the commit that allowed rvalue references
in slot parameters.
@slavaandrejev
Copy link
Contributor Author

You are right. I made the correspondent changes.

@kjellahl kjellahl merged commit cc857ba into libsigcplusplus:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavaandrejev @kjellahl